Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Sphinx to 7.2.5 #1155

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Bump Sphinx to 7.2.5 #1155

merged 5 commits into from
Aug 31, 2023

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 23, 2023 •
edited by github-actions bot
Loading

This also removes _asset_hash(), which is no longer needed.

A

📚 Documentation preview 📚: https://cpython-devguide--1155.org.readthedocs.build/

@AA-Turner AA-Turner added the dependencies Pull requests that update a dependency file label Aug 23, 2023
@AA-Turner AA-Turner marked this pull request as draft August 23, 2023 23:11
@hugovk
Copy link
Member

hugovk commented Aug 24, 2023 

Running Sphinx v7.2.3

Exception occurred:
  File "/home/runner/work/devguide/devguide/venv/lib/python3.11/site-packages/notfound/extension.py", line 337, in setup
    from sphinx.builders.html import setup_js_tag_helper
ImportError: cannot import name 'setup_js_tag_helper' from 'sphinx.builders.html' (/home/runner/work/devguide/devguide/venv/lib/python3.11/site-packages/sphinx/builders/html/__init__.py)

This is readthedocs/sphinx-notfound-page#219.

@hugovk hugovk mentioned this pull request Aug 24, 2023
Closed
hugovk
hugovk reviewed Aug 30, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
hugovk
hugovk reviewed Aug 30, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@AA-Turner @hugovk
Bump notfound-page to 1.0
32ce915 
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cpython-devguide--1155.org.readthedocs.build/ is working now, thanks!

@AA-Turner AA-Turner marked this pull request as ready for review August 30, 2023 14:55
@AA-Turner AA-Turner changed the title Bump Sphinx to 7.2.3 Bump Sphinx to 7.2.4 Aug 30, 2023
@AA-Turner AA-Turner changed the title Bump Sphinx to 7.2.4 Bump Sphinx to 7.2.5 Aug 30, 2023
@hugovk hugovk merged commit b70b763 into python:main Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @hugovk